Add basic support for Microchip PIC32CZ CA Family devices #97787
Conversation
| /* Memory configuration: Flash size, RAM Size and Data Flash size for 1051 memory variants */ | ||
|
|
There was a problem hiding this comment.
superfluous comment in every file? The filename indicates that. Remove from all files
There was a problem hiding this comment.
Thank you @nordicjm for the comment.
I can keep the bare minimum text as the comment.
As this file name indication varies for certain other dtsi files
For eg:
[pic32cz_1051_ca.dtsi] - memory variant 1051
[pic32cz_ca_100.dtsi] - pin count 100
So a simple comment like this will be helpful I guess - " /* 1051 memory variants */ "
Shall I make that change in all files?
There was a problem hiding this comment.
we don't need comments in all the files, what other soc has a comment in every file like that? The point in a comment is to allow someone to understand the way something works or why a specific thing was done, if all it does is describe what is already known by looking at e.g. the filename then the comment is worthless. Do we have comments in board README files e.g.
# this is the README for the native_sim board
in boards/native_sim/docs/index.rst ?
There was a problem hiding this comment.
Thank you @nordicjm for the clarification, I will remove all unwanted comments from these files
There was a problem hiding this comment.
Updated as per your comment @nordicjm
There was a problem hiding this comment.
@AzharMCHP , I reviewed the removal of comments. I agree with @nordicjm about removing redundant info as comments. But, how are you now differentiating pin variant configuration and memory variant configuration? It is not evident from file name
NhMchp
added
the
platform: Microchip SAM
Adds common and SoC-specific .dtsi files for the Microchip PIC32CZ CA80 CA90 and CA91 family. These files define core peripherals, address maps, and interrupt controller structure shared across the PIC32CZ CA80 9x variants. Signed-off-by: Mohamed Azhar <[email protected]>
Adds initial SoC-level support for the Microchip PIC32CZ CA80/9x series, including SoC definition files. Signed-off-by: Mohamed Azhar <[email protected]>
Add initial support for the PIC32CZ CA80 Curiosity Ultra Development Board Product page: https://www.microchip.com/en-us/development-tool/ev51s73a Signed-off-by: Mohamed Azhar <[email protected]>
AzharMCHP
force-pushed
the
pic32cz_ca_minimal_support
branch
from
4fe186c to
9c443ad
Compare
|
zephyrbot
added
area: Boards/SoCs
platform: Microchip MEC
|
|
||
| 2. Connect the Board | ||
|
|
||
| - Connect the `J32 Debug Probe <https://www.microchip.com/en-us/development-tool/dv164232>`_ to the board's **CORTEX DEBUG** header. |
There was a problem hiding this comment.
nit: Mouser Electronics, DigiKey, Microchip Direct, indicate DV164232 as Obsolete / End of life / Out of stock.
Is there any debug probe that supports PIC32CZ CA and is available for purchase?
There was a problem hiding this comment.
would be nice to have this with transparent background - see below
7 participants
This PR adds initial support for Microchip’s PIC32CZ CA family of SoCs, along with board support for the PIC32CZ CA80 Curiosity Ultra development board (EV51S73A). It includes the basic SoC integration, devicetree files, and minimal configuration needed to bring up the board with a working blinky.